PHP Coding, Need some assistance in fixing an error Options

[everythingsbs]

How's it going?

I've been editing phpbb boards script lately for a friend of mine' website. I follow the installation guide for adding the code. I finished adding all of the code, upload all of the new files, and check it and it works fine. Then I try to log into the admin cp and i get a Parse error:

CODE

Parse error: parse error, unexpected T_IF in /homepages/27/d171386843/htdocs/forums/admin/admin_users.php on line 840

So I took a look at it but I don't know exactly what a "parse error" is. So I was wondering if somone could enlighten me on this, and also provide a fix too.

Here's the line of code where the error pops up:

CODE

[L839]            $avatar_sql = ", user_avatar = '" . str_replace("\'", "''", $user_avatar_remoteurl) . "', user_avatar_type = " . USER_AVATAR_REMOTE;                         [l840]

Now I added "[L839]" so you can see the lines. I added the entire string, so hopfully that helps.

Thanks.

Ryan

[amir]

You need to reveal a few more lines of the code since i think the text is wrapped meaning that all lines without any line break are split into a few shorter lines & you really didn't include the errorneous line. (or may be it's what this board did to the code)

[everythingsbs]

Amir,

Thanks for the help. I'll upload the entire page itself. It seems that section of code is quiet long.

Ryan

Attached File(s)

 admin_users.php ( 65.71K ) Number of downloads: 30

 

[usr.c]

Did you forget to close a block with a curly brace right before line 840?

[everythingsbs]

I checked and didn't see anything. I can't figure it out though. hrmm..

Ryan

[usr.c]

Lines 839-840:

CODE

else if( !isset( $HTTP_POST_VARS['submit'] ) && $mode != 'save' && !isset( $HTTP_POST_VARS['avatargallery'] ) && !isset( $HTTP_POST_VARS['submitavatar'] ) && !isset( $HTTP_POST_VARS['cancelavatar'] )
        if( isset( $HTTP_GET_VARS[POST_USERS_URL]) || isset( $HTTP_POST_VARS[POST_USERS_URL]) )

Note the missing { at the end of line 839. Add it and see if it helps.

[everythingsbs]

Ali, I sent you a PM.

I've been trying to figure it out and I dontknow PHP at all. I looked up online "php for dummines" pretty much and I don't know where to place the last { .

Ryan

[usr.c]

Hey, Replace those two lines with:

CODE

else if( !isset( $HTTP_POST_VARS['submit'] ) && $mode != 'save' && !isset( $HTTP_POST_VARS['avatargallery'] ) && !isset( $HTTP_POST_VARS['submitavatar'] ) && !isset( $HTTP_POST_VARS['cancelavatar'] ) {
        if( isset( $HTTP_GET_VARS[POST_USERS_URL]) || isset( $HTTP_POST_VARS[POST_USERS_URL]) )

the else if statement was missing an opening curly brace at the end of it. Let me know what happens.

[everythingsbs]

Ali,

I updated the lines with what you gave me and got this error:

CODE

Parse error: parse error, unexpected '{' in /homepages/27/d171386843/htdocs/forums/admin/admin_users.php on line 839

Ryan

[amir]

Try removing that brace & put a closing round bracket at the end of line 839:

CODE

else if( !isset( $HTTP_POST_VARS['submit'] ) && $mode != 'save' && !isset( $HTTP_POST_VARS['avatargallery'] ) && !isset( $HTTP_POST_VARS['submitavatar'] ) && !isset( $HTTP_POST_VARS['cancelavatar'] )

so that it would be

CODE

$HTTP_POST_VARS['cancelavatar'] ) )

Disable wrapping in ur text editor so that line numbers would be refering to correct lines.

I'm wondering how phpbb could contain such errors?!

[everythingsbs]

Well the script that I was installing, is giving me much more errors then I intended. I can't get users to register, I can't update the profile info, and I keep getting a SQL error. So I am going to override the files that I modified with the default files.

Thanks amir and Ali for your help, but now I do fee like it was semi wasted. I did learn something though, and I thank you guys for it.

Ryan